Update datahub to 2.9.0 and remove submodule#354
Conversation
See geonetwork/core-geonetwork#9095 for the motivation.
Fix: attempt to fix CSW filters with empty escapeChar
Clean georchestra/gn repo to match upstream + fix label bug
Using a too clever mime-type guessing could lead to have spring try to serialize resources using Jackson. For example, if a JSON file is sent via the AttachmentsApi, then retrieving it will lead to an error, as the mimetype of the response will be preemptively set to "application/json", which will trigger Spring to (try to) use Jackson to serialize the resources, which does not make sense when the service should just be about dumping the file into the ServletResponse object. This patch also drops the `Files.probeContentType()` from the Java API, which would be also too clever here. Strategy here is to keep as dumb as possible, to avoid triggering too much cleverness from the framework. Tests: runtime tested on dev infrastructure.
fix: use application/octet-stream as default mimetype
Update lastUpdated as ldap has been bumped to 2.6 in latest
It is considered a sensitive info to reveal user identifiers and their profiles, as the field does not seem to be used client side, maybe it is safer just not to index as it is.
fix: remove userinfo field from the ES index
fix: thesaurus retrieval from UI when editing a metadata
…t-dropped fix: delete user saved selections if user is gone
3ccd214 to
d9c1071
Compare
pmauduit
left a comment
There was a problem hiding this comment.
Something which surprised me was why it looks like we have all the geOrchestra customizations appearing into the PR ? This brought some comments which are unrelated to what the PR describes (mainly removing DH submodule / updating embedded DH version), apart from that, LGTM
There was a problem hiding this comment.
(comment on line 1, but actually covers the whole file, as commenting on the whole file gave me an error from github)
I don't get why this file is totally new in the codebase ? I would have expected something which builds GN earlier in the repository history ?
There was a problem hiding this comment.
this is probably something that is specific to the GN from geOrchestra, but I cannot remember why (probably unrelated to the PR though)
There was a problem hiding this comment.
unrelated to the pr, but we could probably remove these 2 profiles, considering that we are now using log4j2 (and probably nobody use them anymore)
|
Closing as embedded in 4.4.10 |
This PR does 3 things: