Skip to content

Update datahub to 2.9.0 and remove submodule#354

Closed
f-necas wants to merge 22 commits into
georchestra-gn4.4.xfrom
update-datahub-to-2.9.0
Closed

Update datahub to 2.9.0 and remove submodule#354
f-necas wants to merge 22 commits into
georchestra-gn4.4.xfrom
update-datahub-to-2.9.0

Conversation

@f-necas

@f-necas f-necas commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

This PR does 3 things:

f-necas and others added 22 commits October 17, 2025 11:19
Fix: attempt to fix CSW filters with empty escapeChar
Clean georchestra/gn repo to match upstream + fix label bug
Using a too clever mime-type guessing could lead to have spring try to
serialize resources using Jackson.

For example, if a JSON file is sent via the AttachmentsApi, then
retrieving it will lead to an error, as the mimetype of the response
will be preemptively set to "application/json", which will trigger
Spring to (try to) use Jackson to serialize the resources, which does
not make sense when the service should just be about dumping the file
into the ServletResponse object.

This patch also drops the `Files.probeContentType()` from the Java API,
which would be also too clever here.

Strategy here is to keep as dumb as possible, to avoid triggering too
much cleverness from the framework.

Tests: runtime tested on dev infrastructure.
fix: use application/octet-stream as default mimetype
Update lastUpdated as ldap has been bumped to 2.6 in latest
It is considered a sensitive info to reveal user identifiers and their
profiles, as the field does not seem to be used client side, maybe it
is safer just not to index as it is.
fix: remove userinfo field from the ES index
fix: thesaurus retrieval from UI when editing a metadata
…t-dropped

fix: delete user saved selections if user is gone
@f-necas f-necas changed the title update-datahub-to-2.9.0 Update datahub to 2.9.0 and remove submodule Mar 27, 2026
@f-necas
f-necas marked this pull request as ready for review March 27, 2026 10:58
@f-necas
f-necas force-pushed the georchestra-gn4.4.x branch from 3ccd214 to d9c1071 Compare May 13, 2026 12:16

@pmauduit pmauduit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something which surprised me was why it looks like we have all the geOrchestra customizations appearing into the PR ? This brought some comments which are unrelated to what the PR describes (mainly removing DH submodule / updating embedded DH version), apart from that, LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comment on line 1, but actually covers the whole file, as commenting on the whole file gave me an error from github)
I don't get why this file is totally new in the codebase ? I would have expected something which builds GN earlier in the repository history ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably something that is specific to the GN from geOrchestra, but I cannot remember why (probably unrelated to the PR though)

Comment thread web/pom.xml
Comment on lines 1681 to 1699

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to the pr, but we could probably remove these 2 profiles, considering that we are now using log4j2 (and probably nobody use them anymore)

@f-necas

f-necas commented May 13, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as embedded in 4.4.10

@f-necas f-necas closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants